-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reCAPTCHA: Error pages #2585
base: refactor/recaptcha-copy
Are you sure you want to change the base?
reCAPTCHA: Error pages #2585
Conversation
37c0630
to
817bae4
Compare
benefits/static/css/variables.css
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't change or touch this file at all.... the linter did this!
e24f966
to
b47401d
Compare
I noticed that the transit agency name bolding on agency links is a regression on |
d38b680
to
812446c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice clean ups 👍
closes #2545
What this PR does
error-base.html
(previously waserror.html
). Now both Admin and Benefits have anerror-base
. Thebase
naming is used like this now:, to let the developer know that this is a template that inherits from
base.html
, and other templates then inherit it.error-base.html
now makes it so that there is one place to make these changes, making it easier to review also. When making a new error page that is based on this template/design, the developer should not have to write any padding/margin/centering/alignment classes or code. They should only have to write copy (headline-text), create a new or use an existinginclude
s for an icon, add any<p>
of text, and use an existing button, or create a new one (the button might have existing CSS classes, likelogin
). But there shouldn't be a need for any newrow
s orjustify-content-centers
orcol-lg-6
. That is the responsibility of theerror-base
template.How
error-base
works:Error pages
Side note outside of the scope of this PR/Milestone
agency-links
, but it's not. Not part of this PR.Start Here
andReturn home
andTry again
. Not part of this PR.reenrollment-error--calfresh
andstart--medicare
at least. Not sure why. Not part of this PR.